[openstack-dev] [Ironic] Removal of tempest plugin code from openstack/ironic & openstack/ironic-inspector
Sam Betts (sambetts)
sambetts at cisco.com
Tue Dec 19 17:59:56 UTC 2017
Quick update for third party CI owners, if you are using “DEVSTACK_GATE_TEMEPST_ALL_PLUGIN=1” in your CI you will need to disable that and use the TEMPEST_PLUGINS+= in your local config as described below to enable *only* the ironic-tempest-plugin. If you have …TEMPEST_ALL_PLUGIN=1 set it’ll load both versions of the tempest plugin (from ironic and ironic-tempest-plugin) in a non-deterministic order resulting in non-deterministic results from your CI.
On 19/12/2017, 16:54, "John Villalovos" <openstack.org at sodarock.com<mailto:openstack.org at sodarock.com>> wrote:
Please feel free to reach out to me (jlvillal) on IRC (#openstack-ironic) or here if anyone has questions on how to transition over. For our Ironic jobs it was about a 4 line change per job.
See the openstack/ironic patch here: https://review.openstack.org/#/c/527730/
Basically need to bring in the openstack/ironic-tempest-plugin project
And then change TEMPEST_PLUGINS references to /opt/stack/new/ironic to /opt/stack/new/ironic-tempest-plugin:
-export DEVSTACK_LOCAL_CONFIG+=$'\n'"TEMPEST_PLUGINS+=' /opt/stack/new/ironic'"
+export DEVSTACK_LOCAL_CONFIG+=$'\n'"TEMPEST_PLUGINS+=' /opt/stack/new/ironic-tempest-plugin'"
On Tue, Dec 19, 2017 at 7:50 AM, <Rajini.Karthik at dell.com<mailto:Rajini.Karthik at dell.com>> wrote:
Dell - Internal Use - Confidential
Dell Ironic Ci is failing on this patch because of that. With holidays and many on vacation, would appreciate some additional time to make the switch.
From: Ruby Loo [mailto:opensrloo at gmail.com<mailto:opensrloo at gmail.com>]
Sent: Tuesday, December 19, 2017 8:48 AM
To: OpenStack Development Mailing List (not for usage questions) <openstack-dev at lists.openstack.org<mailto:openstack-dev at lists.openstack.org>>
Subject: Re: [openstack-dev] [Ironic] Removal of tempest plugin code from openstack/ironic & openstack/ironic-inspector
On Mon, Dec 18, 2017 at 11:29 PM, <Arkady.Kanevsky at dell.com<mailto:Arkady.Kanevsky at dell.com>> wrote:
Thanks for response.
My recommendation is:
1. only allow patches into openstack/ironic-tempest-plugin
2. Give Ironic CI owners time period (3 weeks?) to switch their setup to only use openstack/ironic-tempest-plugin and not master and report back to Ironic CI team if it works for them. If yes, go ahead and switch if not, report back.
3. At the end of that time, if majority of Ironic CI site complete their transition to ironic-tempest-plugin we switch.
I think this is reasonable. I cringe at knowingly doing something that will most likely break the third party CI when people are away and cannot address it. Also, apart from the danger that the third party CIs are running old versions of the tempest plugins (I doubt that we'll be doing major overhaul of that in the next 2+ weeks), the reason we have 3rd party CI is to make sure patches work against those HW. Having most or all of them being unavailable due to this breakage means that there won't be any feedback that someone's code would have broken 3rd party CI outside of the tempest changes.
John, don't you have a patch that removes the tempest plugin from master? Do most/all of the 3rd party CIs fail due to that? (Or is it not as simple as that?) Ah, yes, https://review.openstack.org/#/c/527733/ shows that all the 3rd party CI fail (although I don't know if it is due to that patch or if they were already failing prior to that).
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe<http://OpenStackfirstname.lastname@example.org?subject:unsubscribe>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev