[openstack-dev] [tacker] [hacking] [requirements] pep8 to pycodestyle
coolsvap at gmail.com
Tue Dec 12 03:57:01 UTC 2017
On Tue, Dec 12, 2017 at 4:37 AM, Ben Nemec <openstack at nemebean.com> wrote:
> It's probably worth noting here that this is to reflect an upstream rename
> from pep8 to pycodestyle, not an actual change in the library we use for
> style checking. It's mentioned in the commit messages, but for anyone just
> scanning the mailing list it may not be obvious.
> I left a review on the hacking change. I think the comments there about
> shadowing the flake8 module name are valid and we should undo/fix that
> before merging. Otherwise I'm +2.
> On 12/04/2017 10:19 PM, Swapnil Kulkarni wrote:
>> We have a change  out there which will remove pep8 and use
>> pycodestyle in global requirements. For this change to be merged we
>> need all dependent projects to use the same and check if they have any
>> conflicts. We are waiting for  for hacking and  for tackerclient
>> to be merged so that we can merge  into global requirements.
>> Requesting the cores in the hacking and tacker group to have a look
>> into this and help us move further. Feel free to reply or drop by
>> #openstack-requirements if you have any questions. Thanks in advance.
>>  https://review.openstack.org/#/c/514663/
>>  https://review.openstack.org/#/c/514934/
>>  https://review.openstack.org/#/c/517450/
Thanks Ben for your review.
More information about the OpenStack-dev