[openstack-dev] [tripleo] Gate is broken - Do not approve any patch until further notice

Jeremy Stanley fungi at yuggoth.org
Wed Aug 30 13:03:23 UTC 2017


On 2017-08-30 08:33:09 -0400 (-0400), Paul Belanger wrote:
[...]
> Regarding Bug 1713832 - Object PUT failed for
> zaqar_subscription[1], which was reverted last night. That is a
> great example to showcase elastic-recheck, basically if you look
> back at the logstash queries, you can see the signs pointing to an
> issue, but unfortunatly wasn't picked up until yesterday.
> 
> The info above from Bogdan is great, the general idea is, if a job
> fails in the check pipeline and elastic-recheck doesn't leave a
> comment, it is likely a new failure. Moving forward, we need to
> keep the blind rechecks to a minimum, as each time we do so, we
> have the potential for breaking the gate down the road.
[...]

And while it doesn't seem to have been exactly the case for this
one, we've seen plenty of examples in the past where people (on
various teams) have blindly rechecked a failing change to get it to
merge... and then when you later classify the bug and track it back
you find that it hit several times in the check pipeline on the very
change which introduced the problem to begin with. Point being if
you recheck without knowing why/what broke, it's increasingly likely
you'll break things for everyone else too and turn a few moments of
inconvenience for yourself into a week or more of pain for many
others.
-- 
Jeremy Stanley
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: Digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170830/ab5c3d9d/attachment.sig>


More information about the OpenStack-dev mailing list