[openstack-dev] [nova] Can we remove the monkey_patch_modules config option?

Alex Schultz aschultz at redhat.com
Mon Aug 28 14:51:19 UTC 2017


On Fri, Aug 25, 2017 at 3:51 PM, Matt Riedemann <mriedemos at gmail.com> wrote:
> I'm having a hard time tracing what this is necessary for. It's related to
> the notify_decorator which is around for legacy notifications but I don't
> actually see that decorator used anywhere. Given there are other options
> related to the notify_decorator, like "default_publisher_id" if we can start
> unwinding and removing this legacy stuff it would make the config (.005%)
> simpler.
>
> It also just looks like we have a monkey_patch option that is run at the
> beginning of every service, uses monkey_patch_modules and if loaded, monkey
> patches whatever is configured for modules.
>
> I mean, if we thought hooks were bad, this is pretty terrible.
>

JFYI, https://review.openstack.org/#/c/494305/

Since this was just added, someone is looking to use it or is using it.

Thanks,
-Alex

> --
>
> Thanks,
>
> Matt
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



More information about the OpenStack-dev mailing list