[openstack-dev] [ironic] support for various glance image reference formats - do we need them all?
dtantsur at redhat.com
Tue Aug 8 16:13:31 UTC 2017
Thanks for raising this.
On 08/07/2017 02:47 PM, Pavlo Shchelokovskyy wrote:
> Hi all,
> currently our GlanceImageService seems to support several ways of defining a
> reference to glance image:
> 1) simple image UUID 
> 2) image UUID prefixed with 'glance://' protocol  (well, actually anything
> starting with 'glance://' and ending with '/<uuid>')
> 3) full REST path to the image (as in
> http://<glance-api>/v2/images/<image-uuid>), also used to extract the glance API
> address 
> Support for #3 must surely be removed, as we are moving to API endpoint
> discovery from keystone catalog.
> Besides I am pretty sure this code path can not actually be reached currently,
> as the 'is_glance_image' will ignore such image refs and return False for those
> , and 'get_image_service' would also not return the GlanceImageService
> instance for such image refs .
> Hence the question - if it is unusable anyway now, should we execute the
> standard deprecation process when removing support for it or just remove right away?
If unsure, always use the standard process ;) Unless somebody is ready to set up
DevStack, and try it out, and prove that it's completely and hopelessly broken.
> As for the #1 and #2 I do not see any big difference between those, and proposed
> deprecating and eventually removing support for #2 ('glance://' scheme) as part
> of . Two people in review already raised a concern about removing such support.
To be honest, I like glance://<uuid> more, as it makes it obvious where the
image is coming from vs http://. I don't mind removing it too much, but I guess
supporting it is not a lot of code, right?
> Thus I'd like to ask a broader audience - do we need support for glance image
> references in 'glance://*<UUID>' form? Is it actually used somewhere? What are
> the benefits of having it besides simple UUID?
>  https://review.openstack.org/#/c/467728
> Dr. Pavlo Shchelokovskyy
> Senior Software Engineer
> Mirantis Inc
> www.mirantis.com <http://www.mirantis.com>
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
More information about the OpenStack-dev