[openstack-dev] [keystone][api] Backwards incompatible changes based on config

Doug Hellmann doug at doughellmann.com
Sat Aug 5 15:47:47 UTC 2017


Excerpts from Morgan Fainberg's message of 2017-08-04 14:52:18 -0700:
> On Fri, Aug 4, 2017 at 2:43 PM, Kevin L. Mitchell <klmitch at mit.edu> wrote:
> > On Fri, 2017-08-04 at 16:45 -0400, Kristi Nikolla wrote:
> >> Is this the case even if we haven’t made any final release with the change
> >> that introduced this issue? [0]
> >>
> >> It was only included in the Pike milestones and betas so far, and was not
> >> part of the Ocata release.
> >
> > Maybe not, but please do recall that there are many deployers out there
> > that track master, not fixed releases, so we need to take that level of
> > compatibility into account.
> >
> 
> I am going to go out on a limb and say that we should not assume that
> if code merges ever it is a contract because someone might be
> following master. The contract should be for releases. We should do
> everything we can to avoid breaking people, but in the case of an API
> contract (behavior) that was never part of a final release, it should
> be understood this may change if needed until it is released.
> 
> This is just my $0.002 as this leads rapidly to "why bother having
> real releases" if everything is a contract, let someone take a
> snapshot where they're happy with the code to run. You're devaluing
> the actual releases.

I'm out here on this limb with you.

Doug

> 
> >> Therefore the call which now returns a 403 in master, returned a 2xx in
> >> Ocata. So we would be fixing something which is broken on master rather
> >> than changing a ‘contract’.
> >>
> >> 0. https://github.com/openstack/keystone/commit/51d5597df729158d15b71e2ba80ab103df5d55f8
> >
> > I would be inclined to accept this specific change as a bug fix not
> > requiring a version bump, because it is a corner case that I believe a
> > deployer would view as a bug, if they encountered it, and because it
> > was introduced prior to a named final release.
> > --
> > Kevin L. Mitchell <klmitch at mit.edu>
> > __________________________________________________________________________
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> 



More information about the OpenStack-dev mailing list