Open Stack

Most projects landed fixes for oslo.config 4.0.  Keystone needs more effort
to make the unit test pass. In addition to
https://review.openstack.org/#/c/455391/  which fixes most of failures.
There are other failures [1] , I created a bug [2] for Keytone.  These
chagnes are related with Keystone domain knowlege , I only tried to fix
simple ones. so keystone team, please help dig, thanks

[1]
http://logs.openstack.org/periodic/periodic-keystone-py27-with-oslo-master/0868d74/testr_results.html.gz
[2] https://bugs.launchpad.net/keystone/+bug/1686921



2017-04-16 15:32 GMT+08:00 ChangBo Guo <glongwave at gmail.com>:

> As I expect, there are some failures in periodic tasks recently [1] if we
> set enforce_type with True by default,  we'd better fix them before we
> release oslo.config 4.0.  Some guys had been working on this :
> Nova: https://review.openstack.org/455534 should fix failures
> tempest:  https://review.openstack.org/456445 fixed
> Keystone:  https://review.openstack.org/455391 wait for oslo.config 4.0
>
> We still need help from Glance/Ironic/Octavia
> Glance:  https://review.openstack.org/#/c/455522/ need review
> Ironic:  Need fix failure in http://logs.openstack.org/
> periodic/periodic-ironic-py27-with-oslo-master/680abfe/
> testr_results.html.gz
> Octavia: Need fix failure in http://logs.openstack.org/
> periodic/periodic-octavia-py35-with-oslo-master/80fee03/
> testr_results.html.gz
>
> [1] http://status.openstack.org/openstack-health/#/?groupKey=
> build_name&resolutionKey=hour&searchProject=-with-oslo
>
> 2017-04-04 0:01 GMT+08:00 ChangBo Guo <glongwave at gmail.com>:
>
>> Hi ALL,
>>
>> oslo_config provides method CONF.set_override[1] , developers usually use
>> it to change config option's value in tests. That's convenient . By
>> default  parameter enforce_type=False,  it doesn't check any type or
>> value of override. If set enforce_type=True , will check parameter
>> override's type and value.  In production code(running time code),
>> oslo_config  always checks  config option's value. In short, we test and
>> run code in different ways. so there's  gap:  config option with wrong
>> type or invalid value can pass tests when
>> parameter enforce_type = False in consuming projects.  that means some
>> invalid or wrong tests are in our code base.
>>
>>
>> We began to warn user about the change since Sep, 2016 in [2]. This
>> change will notify consuming project to write correct test cases with
>> config options.
>> We would make enforce_type = true by default in [3], that may break some
>> projects' tests, that's also raise wrong unit tests. The failure is easy to
>> fix, which
>> is recommended.
>>
>>
>> [1] https://github.com/openstack/oslo.config/blob/efb287a94645b1
>> 5b634e8c344352696ff85c219f/oslo_config/cfg.py#L2613
>> [2] https://review.openstack.org/#/c/365476/
>> [3] https://review.openstack.org/328692
>>
>> --
>> ChangBo Guo(gcb)
>>
>
>
>
> --
> ChangBo Guo(gcb)
>



-- 
ChangBo Guo(gcb)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170428/3714873d/attachment.html>