Open Stack

> On 03 Sep 2016, at 20:07, Duncan Thomas <duncan.thomas at gmail.com> wrote:
> 
> There's also another API limitation to be fixed - whether it goes in the initial API fixup or gets done later, which is a round one cinder serving multiple nova or other consumers: https://review.openstack.org/#/c/362637/ <https://review.openstack.org/#/c/362637/>
Thanks Duncan, I added it to our etherpad to keep an eye on this one too.

> 
> On 2 September 2016 at 22:51, Matt Riedemann <mriedem at linux.vnet.ibm.com <mailto:mriedem at linux.vnet.ibm.com>> wrote:
> On 9/1/2016 4:09 PM, Ildiko Vancsa wrote:
> Hi All,
> 
> 
> We had an attempt to remove ‘check_attach’ from the Nova code, as this check should be purely Cinder’s responsibility. The call is partially removed [4] and there’s one patch up for review to finish that work item [5]. The difficulty with this one is that we have one flow that missed the ‘reserve_volume’ call and therefore also the required checks on Cinder side. This is corrected in the patch up for review [5], it needs some more eyes on it to ensure we have the proper fix.
> 
> I haven't gone through the new experimental APIs proposed in cinder but while Walter was working on [4] we realized a gap in the os-reserve call in that we should pass the availability zone since nova still has to check that separately:
> 
> https://github.com/openstack/nova/blob/96926a8ee182550391c30b16b410da7f598c0f39/nova/volume/cinder.py#L290 <https://github.com/openstack/nova/blob/96926a8ee182550391c30b16b410da7f598c0f39/nova/volume/cinder.py#L290>
> 
> That seems like something we could do separately early in ocata with a microversion on the os-reserve API to take an optional availability_zone argument and fail if it doesn't match the AZ for the volume being reserved.

@Matt: Do you mean to remove check_attach along with check_availability_zone in one step, when we have os-reserve properly fixed?

Thanks,
Ildikó


> 
> 
> [5] https://review.openstack.org/#/c/335358/ <https://review.openstack.org/#/c/335358/>
> -- 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160905/9c7d64c1/attachment.html>