Open Stack

On Mon, Oct 03, 2016 at 02:23:08PM +0200, Marius Cornea wrote:
> Hello everyone,
> 
> In Newton we've deprecated the *-scale and *-flavor deploy command
> arguments in favor of using Heat environment files. In the context of
> testing the composable roles where the custom roles' node count and
> flavor need to be passed inside an environment file I would like to
> build the test plan by using an environment containing all nodes count
> and flavors, including the preexisting roles.
> 
> A deploy command example would look like:
> 
> openstack overcloud deploy --stack cloudy --templates -e nodes.yaml
> 
> where the nodes environment file contains something like:
> 
> parameter_defaults:
>   ControllerCount: 3
>   ComputeCount: 2
>   CephStorageCount: 3
>   ServiceApiCount: 3
> 
>   OvercloudControlFlavor: controller
>   OvercloudComputeFlavor: compute
>   OvercloudCephStorageFlavor: ceph
>   OvercloudServiceApiFlavor: serviceapi
> 
> 
> I would like to get some feedback about this approach. I think it's
> better to keep all the roles count/flavors in the same place for
> consistency reasons.

+1 - I think this is well aligned with the interfaces we want to encourage
(vs the hard-coded CLI options which we want to move away from).

The only disadvantage of this approach is there's a few special-cases where
the parameter name isn't intuitive (OvercloudControlFlavor is an example).

It'd be better if we move to a consistent e.g $roleFlavor interface in due
course), but I still think encouraging this pattern is good, as it'll help
us identify the parameter interfaces which are inconsistent, then we can
fix them (deprecate the old parameter, add new consistent ones).

Thanks,

Steve