[openstack-dev] Making changes to gerrit's presentation

Chris Dent cdent+os at anticdent.org
Tue May 10 11:32:28 UTC 2016

On Tue, 10 May 2016, Sean Dague wrote:

> Gerrit's is a GWT app, which means the entire thing is Java which
> compiles to HTML/JS, for anything deep, you have to dive down that
> rabbit hole.

Thanks for the response, this is pretty much what I feared. If I
find some some cycles I may go exploring over in the gerrit
community, but the pain threshold may not have been crossed yet.

> https://review.openstack.org/#/c/313532/9 - you will fine the Line: ###
> are actually clickable and provide links of the format -
> https://review.openstack.org/#/c/313532/9/api-ref/source/servers.inc@553
> That will put L553 on the new side at the center of the page, and stick
> the cursor there (which is subtle).

Yeah knew about that one, but it's not what I'm trying to do[1]. I want
to link to an individual response on the front page of a given review
(not on a specific file). On review with any sane number of patchsets
this isn't too hard to talk about, but when there are many patchsets and
many reviews it gets more difficult. "Nancy's response to patchset 42"
is good enough when speaking to someone who is gerrit savvy, but less
good when you're trying to gain some input from an outside-the-
community expert.

[1] It also doesn't work if you're a unified diff user.

Chris Dent               (╯°□°)╯︵┻━┻            http://anticdent.org/
freenode: cdent                                         tw: @anticdent

More information about the OpenStack-dev mailing list