[openstack-dev] [ironic] simple patches requiring only one +2/+A

Loo, Ruby ruby.loo at intel.com
Tue Jun 14 17:37:42 UTC 2016


Hi,

There was a short discussion on IRC a few minutes ago [1] about when it would be acceptable for a patch to be approved with one +2 (as opposed to two +2s). The few of us that commented (I think all are cores in one or several ironic projects) agreed that it would be good to do that, but "use your common sense" didn't seem to provide enough guidance :)

I've updated our wiki [2] (see bullet 4, bullet 2) to reflect what I think we agreed on. It didn't seem necessary to vote on it. Please let me/us know if you disagree or have other comments.

(I know, we should move this information from the wiki to our documentation, but that's a separate issue.)

Thanks,
--ruby


[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2016-06-14.log.html#t2016-06-14T16:51:40
[2] https://wiki.openstack.org/wiki/Ironic/CoreTeam#Other_notes



More information about the OpenStack-dev mailing list