[openstack-dev] [TripleO] Removing unused/deprecated template parameters?

Jiri Tomasek jtomasek at redhat.com
Wed Jan 13 09:43:31 UTC 2016


On 01/13/2016 10:33 AM, Juan Antonio Osorio wrote:
> IIRC some of them were already marked (via a comment) as deprecated.
>
> +1 to cleaning up the parameters. I think it should be done as soon as 
> possible, as the existence of some of them makes the usage of the 
> templates quite confusing.
>
> BR
>
> On Tue, Jan 12, 2016 at 10:47 PM, Steven Hardy <shardy at redhat.com 
> <mailto:shardy at redhat.com>> wrote:
>
>     Hi all,
>
>     I've noticed that we have a fairly large number of unused
>     parameters in
>     t-h-t, some of which are marked deprecated, some aren't.
>
>     Since we moved tripleoclient to use parameter_defaults everywhere,
>     I think
>     it should be safe to remove these unused parameters, even in
>     overcloud.yaml.
>
>     See:
>
>     https://review.openstack.org/#/c/227057/
>
>     https://review.openstack.org/#/c/227057/
>
>     Since those, we can pass removed/deprecated parameters from the
>     client and
>     they will be ignored, even if they're removed from the template
>     (unlike if
>     you use "parameters", where a validation error would occur.
>
>     I'd like to go ahead and clean these up (only on the master
>     branch), is
>     that reasonable?  We can document the change via a mitaka release
>     note?
>
>     Ideally, we'd have user-visible warnings for a deprecation period, but
>     there's no way to output such warnings atm via heat, so we'd need
>     to wire
>     them in via tripleoclient or tripleo-common, which seems a bit
>     backwards
>     given that we can just remove the parameters there instead.
>
>     Thoughts?
>
>     Steve
>
>     __________________________________________________________________________
>     OpenStack Development Mailing List (not for usage questions)
>     Unsubscribe:
>     OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>     <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
>     http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
>
> -- 
> Juan Antonio Osorio R.
> e-mail: jaosorior at gmail.com <mailto:jaosorior at gmail.com>
>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

+1 IUC this will reduce the number of parameters returned by nested heat 
validate, which is a good thing as those parameters confuse user.

Jirka
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160113/de00ac4e/attachment.html>


More information about the OpenStack-dev mailing list