[openstack-dev] [Horizon][stable] proposing Rob Cresswell for Horizon stable core
mriedem at linux.vnet.ibm.com
Tue Apr 19 15:41:07 UTC 2016
On 4/12/2016 5:06 AM, Matthias Runge wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> On 12/04/16 05:12, Tony Breeds wrote:
>> On Thu, Apr 07, 2016 at 12:01:31PM +0200, Matthias Runge wrote:
>>> I'm proposing Rob Cresswell to become stable core for Horizon. I
>>> thought, in the past all PTL were in stable team, but this
>>> doesn't seem to be true any more.
>> This *may* have been true when the project specific team were
>> created, which was before my time, but it isn't true now.
>>> Please chime in with +1/-1
>> As with core status in other parts of OpenStack its merit /
>> evidence based. That is to say if you're doing good work, showing
>> an understanding of the stable policy then great lets do this
>> A quite check of reviewstats:
>> stable-liberty-horizon-120.txt :
>> http://paste.openstack.org/show/493706 stable-kilo-horizon-120.txt
>> : http://paste.openstack.org/show/493707
>> Shows that Rob has done 2 stable reviews in the last 120 days.
>> This is absolutely no reflection on Rob's contribution to Horizon
>> as a whole.
> We never took review stats for stable branches as basis for proposing
> or voting for someone being stable-maint.
> In the past, people were proposed (and approved) to become stable
> maintainer, because people were convinced the new person will care
> about stable status in Horizon.
> And after approval, someone would act as mentor to educate the new
> core on stable review guidelines. That's a quite lightweight process,
> it currently didn't fail for us, and we're in the situation, where
> we're desperately looking for stable reviewers and cores.
> - --
> Matthias Runge <mrunge at redhat.com>
> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
> Commercial register: Amtsgericht Muenchen, HRB 153243,
> Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham,
> Michael O'Neill
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
> -----END PGP SIGNATURE-----
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
I agree with Tony. There is a reason that the project-specific stable
maint core team is not the same as a project's regular core team on the
master branch, and that's because the rules are different for reviews.
So just because you're the PTL doesn't mean you know the stable branch
review policy, which is why, generally, we should see more activity in
reviews on stable branches before granting someone core privileges.
From the stable team meeting today, it sounds like Rob is doing that,
which is great. For the time being, the stable-maint-core team can help
out with approving Horizon backports that have a +2 from the existing
horizon stable cores that are still active (it sounds like there is some
attrition which is prompting a lot of this).
Then we can re-assess after the summit.
BTW, this is in no way a knock against Rob, and I apologize if anyone
feels that way. It's just more about making sure we're comfortable with
the people that are going to be approving changes that impact stable
More information about the OpenStack-dev