[openstack-dev] [oslo][keystone][documentation][gate] Babel dependency for oslo.log

Andreas Jaeger aj at suse.com
Tue Apr 19 14:09:54 UTC 2016

On 2016-04-18 19:42, Joshua Harlow wrote:
> Andreas Jaeger wrote:
>> On 04/17/2016 09:15 PM, Davanum Srinivas wrote:
>>> Hi Oslo folks, Andreas and others,
>>> Over the weekend oslo.log 3.4.0 was released. This broke keystone CI
>>> jobs [2], even though the 3.4.0 was not specified in upper-constraints
>>> as keystone jobs were not honoring the upper-constraints.txt, so we
>>> fixed it in [3].
>>> So the first big problem after [3] was that several tox targets do not
>>> inject u-c and hence fail, so in [3] we also added install_commands
>>> for testenv:releasenotes and testenv:cover, based on the pattern set
>>> in Nova's tox.ini [4]. That was still not enough and we had to add an
>>> entry in keystone's requirements.txt for Babel even though it was not
>>> there before (and hence pulling in latest Babel from somewhere).
>>> So Here are the questions:
>>> 1) Is there anyone working to fix all tox CI jobs to honor upper
>>> constraints?
>>> 2) Why do we need Babel in oslo.log's requirements.txt?
>>> 3) Can we remove Babel from all requirements.txt and
>>> test-requirements.txt and leave them in just tox.ini when needed?
>>> Note that there was nothing wrong either in oslo.log itself it
>>> published a release with what was in global-requirements.txt, nor in
>>> keystone, which has traditionally not run with constraints on. Just
>>> the combination of situations with Babel going bad broke at least
>>> keystone.
>>> Did anyone else see other jobs break? Please respond!
>>> Thanks,
>>> Dims
>>> [1] http://markmail.org/message/ygyxpjpbhlbz3q5d
>>> [2]
>>> http://logs.openstack.org/86/249486/32/check/gate-keystone-python34-db/29ace4f/console.html#_2016-04-17_04_31_51_138
>>> [3] https://review.openstack.org/#/c/306846/
>>> [4] http://git.openstack.org/cgit/openstack/nova/tree/tox.ini
>> I think what happened is:
>> 1) oslo.log indirectly requires Babel
>> 2) requirements blacklists Babel 2.3.x
>> 3) keystone has new requirements included and thus fails
>> The problem here is that oslo.log requires olso.i18n which requires
>> Babel. And if oslo.i18n would have had a release with the blacklisting
>> of Babel 2.3.x, this wouldn't have happened. So, I propose to release
>> oslo.i18n.
>> Babel 2.3.4 which fixes the known problems might be out soon as well -
>> and if that does not introduce regressions, this will self-heal,
> Ok, so which option should we go with here?
> I'm ok with releasing olso.i18n or Babel 2.3.4 (when is this release
> happening, soon? like soon soon?)

The fix is:

I would have expected it to be released already but it isn't - let's
release olso.i18n, please,

 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
       HRB 21284 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126

More information about the OpenStack-dev mailing list