[openstack-dev] [murano] Fix order of arguments in assertEqual

Bulat Gaifullin bgaifullin at mirantis.com
Thu Sep 24 07:58:43 UTC 2015


+1

> On 24 Sep 2015, at 10:45, Tetiana Lashchova <tlashchova at mirantis.com> wrote:
> 
> Hi folks!
> 
> Some tests in murano code use incorrect order of arguments in assertEqual.
> The correct order expected by the testtools is
> 
>         def assertEqual(self, expected, observed, message=''):
>             """Assert that 'expected' is equal to 'observed'.
> 
>             :param expected: The expected value.
>             :param observed: The observed value.
>             :param message: An optional message to include in the error.
>             """
> 
> Error message has the following format:
> 
> raise mismatch_error
>     testtools.matchers._impl.MismatchError: !=:
>     reference = <expected value>
>     actual    = <observed value>
> 
> Use of arguments in incorrect order could make debug output very confusing.
> Let's fix it to make debugging easier.
> 
> Best regards,
> Tetiana Lashchova
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




More information about the OpenStack-dev mailing list