[openstack-dev] [cinder] should we use fsync when writing iscsi config file?

Chris Friesen chris.friesen at windriver.com
Wed Sep 23 00:14:45 UTC 2015


On 09/22/2015 05:48 PM, Joshua Harlow wrote:
> A present:
>
>  >>> import contextlib
>  >>> import os
>  >>>
>  >>> @contextlib.contextmanager
> ... def synced_file(path, mode='wb'):
> ...   with open(path, mode) as fh:
> ...      yield fh
> ...      os.fdatasync(fh.fileno())
> ...
>  >>> with synced_file("/tmp/b.txt") as fh:
> ...    fh.write("b")

Isn't that missing an "fh.flush()" somewhere before the fdatasync()?

Chris






More information about the OpenStack-dev mailing list