[openstack-dev] [infra][all] Reviews with a prio label?
dolph.mathews at gmail.com
Tue Oct 20 17:16:43 UTC 2015
On Tue, Oct 20, 2015 at 12:09 PM, Sean Dague <sean at dague.net> wrote:
> On 10/20/2015 12:43 PM, Dolph Mathews wrote:
> > This is actually something I've thought a lot about (focusing the
> > community's review efforts), and have experimented with various
> > solutions in the keystone community. I've built external solutions that
> > have worked fairly well, but my current preference is to take advantage
> > of what's already built into gerrit: starred reviews and dashboards.
> > For example, here is a dashboard of reviews in the keystone ecosystem
> > starred by any member of keystone-core that *you* have not reviewed
> > yourself (so you'll need to be logged into gerrit for this link to work):
> > http://bit.ly/1GnOuqw 
> > In other words, it's a personalized review queue of things keystone-core
> > deems important.
> > The advantage I see to this approach over a new label is that the star
> > feature is already in the gerrit UI and so people already use it. But
> > broadly speaking, I'm not aware of anyone utilizing that data today as a
> > crowd sourced data point.
> The rally team uses it as part of their dashboard -
> > If you'd like to create your own version of this dashboard, here's the
> > gerrit-dash-creator config file for this dashboard:
> > To customize it for yourself, you'd pretty much only need to edit the
> > [dashboard] section, and specifically the "foreach" value to reflect the
> > right collection of projects and group of reviewers. After that it's a
> > matter of using gerrit-dash-creator to produce the link:
> > https://github.com/openstack/gerrit-dash-creator
> > I'd love to take this a couple steps further if people find the approach
> > valuable. I'd like to regularly recreate these links for every project
> > based on the latest *-core membership, and the latest set of projects in
> > a given community, publish them to permalinks, and share those
> > permalinks with code reviewers.
> One of the challenges you run into is url length limits in browsers,
> given that we're encoding the whole thing in the url.
I haven't run into any issues yet myself, but yes, definitely. One of the
easiest changes I'd make to "compress" the URL is to use user IDs instead
of emails like I did here, e.g.:
> I do think the overall approach has a lot of merrit, though it would
> still be awesome if there was a more baked in tagging in gerrit.
> Sean Dague
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev