[openstack-dev] [infra] Upgrade to Gerrit 2.11

Sean Dague sean at dague.net
Thu Oct 15 10:54:07 UTC 2015

On 10/14/2015 08:22 PM, Ian Wienand wrote:
> On 10/14/2015 11:08 AM, Zaro wrote:
>> We are soliciting feedback so please let us know what you think.
> Since you asked :)
> Mostly it's just different which is fine.  Two things I noticed when
> playing around, shown in [1]
> When reviewing, the order "-1 0 +1" is kind of counter-intuitive to
> the usual dialog layout of the "most positive" thing on the left;
> e.g. [OK] [Cancel] dialogs.  I just found it odd to interact with.
> Maybe people default themselves to -1 though :)
> The colours for +1/-1 seem to be missing.  You've got to think a lot
> more to parse the +1/-1 rather than just glance at the colours.

Oh, -1 color is a site local change to the css IIRC. I think I made that
in in paris. It's something we could do for the new change screen as
well. The css selector is weird, but seems to work fine:

/* css attribute selector to make -1s show up red in new screen */
[title="This patch needs further work before it can be merged"] {
    color: red;


Sean Dague

More information about the OpenStack-dev mailing list