[openstack-dev] [Glance] Process to clean up the review queue from non-active patches

Flavio Percoco flavio at redhat.com
Wed Oct 7 07:37:49 UTC 2015

On 06/10/15 17:54 +0200, Victor Stinner wrote:
>Le 06/10/2015 16:36, Flavio Percoco a écrit :
>>Not so long ago, Erno started a thread[0] in this list to discuss the
>>abandon policies for patches that haven't been updated in Glance.
>>1) Lets do this on patches that haven't had any activity in the last 2
>>months. This adds one more month to Erno's proposal. The reason being
>>that during the lat cycle, there were some ups and downs in the review
>>flow that caused some patches to get stuck.
>Please don't do that. I sent a patch in June (20) and it was only 
>reviewed in October (4)... There was no activity simply because I had 
>nothing to add, everything was explained in the commit message, I was 
>only waiting for a review...
>I came on #openstack-glance to ask for review several time between 
>August and September but nobody reviewed by patches (there was al.
>Example of patch: https://review.openstack.org/#/c/193786/ (now merged)

Yes, I'm very aware of this case and it's great feedback. What
happened with these patches could have (or did happen) with other
patches. The review response is something that I'd definitely like us
to improve and this is not the solution.

>It would be very frustrating to have to resend the same patch over and over.

There's no need to resend the patch. Just commenting saying that it's
still a valid update and it'll keep the patch from being abandoned.


Flavio Percoco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20151007/32c94b97/attachment.pgp>

More information about the OpenStack-dev mailing list