[openstack-dev] [Glance] Process to clean up the review queue from non-active patches

Flavio Percoco flavio at redhat.com
Wed Oct 7 07:04:41 UTC 2015

On 06/10/15 17:52 +0200, Julien Danjou wrote:
>On Tue, Oct 06 2015, Flavio Percoco wrote:
>I send patches to Glance from time to time, and they usually got 0
>review for *weeks* (sometimes months, because, well there are no
>reviewers active in Glance, so:
>> 1) Lets do this on patches that haven't had any activity in the last 2
>> months. This adds one more month to Erno's proposal. The reason being
>> that during the lat cycle, there were some ups and downs in the review
>> flow that caused some patches to get stuck.
>This is going to expire my patches that nobody cares about and that are
>improving the code or fixing stuff people didn't encounter (yet).
>> 3) The patch will be first marked as a WIP and then abandoned if the
>> patch is not updated in 1 week. This will put this patches at the
>> begining of the queue but using the Glance review dashboard should
>> help keeing focus.
>Why WIP? If a patch is complete and waiting for reviewers I'm not sure
>it helps.

WIP because I don't think we should abandon them right away - since
there are patches like yours and Victor's that matter - and there's no
status to say: "I'm sorry we screwed up and we didn't review your
patch. Please come to us and throw all your amazing patches in our
faces so that we'll review them... for realz"

>The problem is that nobody is reviewing Glance patches (except you
>recently it seems). That's not going to solve that. That's just going to
>hide the issues under the carpet by lowering the total of patches that
>needs review…

I'm not trying to solve the lack of reviews in Liberty by removing
patches. What I'd like to do, though, is help to keep around patches
that really matter.

I know there have been a huge lag on reviews which is something that
we'll be working on with a different workflow. The dashboard mentioned
is one of them.

We could certainly increase the number of months.

Thanks a lot for the feedback,

>My 2c,
>Julien Danjou
>;; Free Software hacker
>;; https://julien.danjou.info

Flavio Percoco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20151007/8cb703a5/attachment.pgp>

More information about the OpenStack-dev mailing list