[openstack-dev] [Glance] Process to clean up the review queue from non-active patches

Julien Danjou julien at danjou.info
Tue Oct 6 15:52:28 UTC 2015

On Tue, Oct 06 2015, Flavio Percoco wrote:

I send patches to Glance from time to time, and they usually got 0
review for *weeks* (sometimes months, because, well there are no
reviewers active in Glance, so:

> 1) Lets do this on patches that haven't had any activity in the last 2
> months. This adds one more month to Erno's proposal. The reason being
> that during the lat cycle, there were some ups and downs in the review
> flow that caused some patches to get stuck.

This is going to expire my patches that nobody cares about and that are
improving the code or fixing stuff people didn't encounter (yet).

> 3) The patch will be first marked as a WIP and then abandoned if the
> patch is not updated in 1 week. This will put this patches at the
> begining of the queue but using the Glance review dashboard should
> help keeing focus.

Why WIP? If a patch is complete and waiting for reviewers I'm not sure
it helps.

The problem is that nobody is reviewing Glance patches (except you
recently it seems). That's not going to solve that. That's just going to
hide the issues under the carpet by lowering the total of patches that
needs review…

My 2c,

Julien Danjou
;; Free Software hacker
;; https://julien.danjou.info
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20151006/10043f56/attachment.pgp>

More information about the OpenStack-dev mailing list