[openstack-dev] [all] -1 due to line length violation in commit messages

Jeremy Stanley fungi at yuggoth.org
Mon Oct 5 17:12:16 UTC 2015

On 2015-10-05 12:00:31 -0500 (-0500), Ben Nemec wrote:
> Note that it's best to do this once the change is ready to be
> approved. If you do it earlier and the committer pushes a new
> patch set without fixing the commit message, it will revert the
> fix made through the web interface.

Well, one workflow tweak which avoids that is to always pull the
latest state of your change from Gerrit before you start modifying
it rather than assuming what is in your filesystem is still current.
It also helps to check Gerrit before pushing a new patchset (or lurk
in an IRC channel where the openstackgerrit bot reports uploads for
that repo), making sure nobody else has updated that change while
you were editing.

That said, a lot of developers probably don't do this.
Jeremy Stanley

More information about the OpenStack-dev mailing list