[openstack-dev] [glance] Models and validation for v2

Kuvaja, Erno kuvaja at hpe.com
Thu Oct 1 09:14:59 UTC 2015


We do not validate against schema on image-list (see 43769d6cc7266d7c81db31ad58b4fa403c35b611). This said there was discussion around throwing all that validation code out, exactly like Jay said, we should not validate responses coming from our own servers.

This discussion happened just under 1.0.0 release of glanceclient which moved to defaulting v2 Images API at CLI and we didn’t see it reasonable to wait until we get that validation cleanup done. That said, the work is in pipeline to be done after we get more important things (like Liberty release) out of hands first.

-          Erno

From: Kairat Kushaev [mailto:kkushaev at mirantis.com]
Sent: Wednesday, September 30, 2015 7:33 PM
To: OpenStack Development Mailing List (not for usage questions)
Subject: Re: [openstack-dev] [glance] Models and validation for v2

Agree with you. That's why I am asking about reasoning. Perhaps, we need to realize how to get rid of this in glanceclient.

Best regards,
Kairat Kushaev

On Wed, Sep 30, 2015 at 7:04 PM, Jay Pipes <jaypipes at gmail.com<mailto:jaypipes at gmail.com>> wrote:
On 09/30/2015 09:31 AM, Kairat Kushaev wrote:
Hi All,
In short terms, I am wondering why we are validating responses from
server when we are doing
image-show, image-list, member-list, metadef-namespace-show and other
read-only requests.

AFAIK, we are building warlock models when receiving responses from
server (see [0]). Each model requires schema to be fetched from glance
server. It means that each time we are doing image-show, image-list,
image-create, member-list and others we are requesting schema from the
server. AFAIU, we are using models to dynamically validate that object
is in accordance with schema but is it the case when glance receives
responses from the server?

Could somebody please explain me the reasoning of this implementation?
Am I missed some usage cases when validation is required for server

I also noticed that we already faced some issues with such
implementation that leads to "mocking" validation([1][2]).

The validation should not be done for responses, only ever requests (and it's unclear that there is value in doing this on the client side at all, IMHO).


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe<http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20151001/82d54f79/attachment.html>

More information about the OpenStack-dev mailing list