Open Stack

On 11/03/2015 02:57 PM, Emilien Macchi wrote:
> I'm seeing a lot of patches using the new $::os_service_default.
>
> Please stop trying to using it at this time. The feature is not stable
> yet and we're testing it only for puppet-cinder module.
> I've heard Yanis found something that is not backward compatible with
> logging, but he's away this week so I suggest we wait next week.
>
> In the meantime, please do not use $::os_service_default outside
> puppet-cinder.
>
> Thanks a lot,
After a deeper investigation, the issue with logging[1] is only true if
a user is using the puppet-openstack to only configure the component and
not relying on it to install the RDO/UCA packages.

On RDO, the file /usr/lib/systemd/system/openstack-cinder-api.service is
provided. It specifies :

  ExecStart=/usr/bin/cinder-api --config-file
/usr/share/cinder/cinder-dist.conf \
    --config-file /etc/cinder/cinder.conf --logfile /var/log/cinder/api.log

On Ubuntu, the file /etc/init/cinder-api.conf is provided. It specfies :

  exec start-stop-daemon --start --chuid cinder --exec /usr/bin/cinder-api \
     -- --config-file=/etc/cinder/cinder.conf
--log-file=/var/log/cinder/cinder-api.log

In my understanding, this means that when using packages none of log-dir
and log-file will ever be taken in account.

So the only use case moving those values to $::os_service_default might
impact are for the people relying directly on the python package.

This raises two questions I'd like to ask :

  * Do lot of people use puppet-openstack modules relying on the python
package directly ?
  * Should we be opinionated here ? If user relies on the python
packages, we can consider that an advanced use-case and expect the user
to know exactly what she needs to configure. Plus we do not handle the
use case where we want a file for cinder-volume.log and cinder-backup.log.

[1]
https://trello.com/c/XLJJJBF0/71-move-modules-to-the-os-service-default-pattern

--
Yanis Guenane