[openstack-dev] [oslo] XxxOpt classes "kept for backward-compatibility" in oslo.config

Doug Hellmann doug at doughellmann.com
Tue Nov 10 14:43:09 UTC 2015


Excerpts from Victor Stinner's message of 2015-11-10 15:30:18 +0100:
> Hi,
> 
> In oslo_config/cfg.py, there is a main Opt class which takes an optional 
> type parameter (default is oslo_config.types.String). But there is also 
> a long list of XxxOpt classes: StrOpt, BoolOpt, FloatOpt, ListOpt, 
> IPOpt, etc. Recently I saw *new* classes added with the "kept for 
> backward-compatibility" comment, comment copied from existing classes.
> 
> What is the plan for these XxxOpt classes? Is there a clear plan to 
> deprecate them and remove them? Or can we agree on keeping them and so 
> removing the comment?
> 
> It looks like oslo_config.cfg.Opt is *never* used directly in OpenStack. 
> Only specialized options StrOpt, IntOpt etc. are used.
> 
> So the obvious choice is to remove the comment, right?
> 
> Victor
> 

+1 for removing the comment.

I think the intent was to have folks use Opt with type set to something
specific, but that's a lot of rework for little gain.

Doug



More information about the OpenStack-dev mailing list