[openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

Ryan Brown rybrown at redhat.com
Thu Mar 26 20:14:31 UTC 2015


On 03/26/2015 02:15 PM, Kiall Mac Innes wrote:
> I have no clue how I managed to send that last email encrypted -
> Apologies :)
> 
> Re YAPF, or autofomatting, I've very little opinion..
> 
> But - I gave YAPF a go against the Designate codebase with the stock config:
> 
>   258 files changed, 5242 insertions(+), 5691 deletions(-)
> 
> Getting changes like that into the various projects won't be easy, even
> if the core team is happy to just +A without reviewing for potential
> issues, a massive percentage of in-progress reviews will fail to merge
> and need manual rebasing.
> 
> For companies with internal forks/patches - those will likely all have
> to be redone too..

Ooof, that's huge. If we can configure it to be less aggressive I love
the *idea* of having everything formatted semantically, but that's a
pretty major burden for everyone involved.

-- 
Ryan Brown / Software Engineer, Openstack / Red Hat, Inc.



More information about the OpenStack-dev mailing list