Open Stack

On 03/12/2015 05:29 PM, Mike Bayer wrote:

<snip>

> If we assume that all of our tables are filled up with zeroes for those
> deleted columns, because that’s the default, this **wipes the whole table
> clean**.
>
> How do the tests pass? Well the tests are in test_db_api->ArchiveTestCase,
> and actually, they don’t. But they don’t fail every time, because the test
> suite here runs with a database that is almost completely empty anyway, so
> the broken archival routine doesn’t find too many rows to blow away except
> for the rows in “instance_types”, which it only finds sometimes because the
> tests are only running it with a small number of things to delete and the
> order of the tables is non-deterministic.
>
> I’ve posted the bug report at https://bugs.launchpad.net/nova/+bug/1431571
> where I started out not knowing much about how this worked except that my
> tests were failing, and slowly stumbled my way to come to this conclusion. A
> patch is at https://review.openstack.org/#/c/164009/, where we look at the
> actual Python-side default. However I’d recommend that we just hardcode the
> zero here, since that’s how our soft-delete columns work.

Nice detective work.  I imagine there was some hair pulling on that one...

Chris