Open Stack

+1 Murali. AFIAK, there is no precedent for what Keith proposes, but that doesn't mean its a bad thing.

On Jun 16, 2015, at 12:21 AM, Murali Allada <murali.allada at RACKSPACE.COM> wrote:

> I agree, users should have a mechanism to keep logs around.
> 
> I implemented the logs deletion feature after we got a bunch of requests from users to delete logs once they delete an app, so they don't get charged for storage once the app is deleted.
> 
> My implementation deletes the logs by default and I think that is the right behavior. Based on user requests, that is exactly what they were asking for. I'm planning to add a --keep-logs flag in a follow up patch. The command will look as follows
> 
> Solum delete app MyApp --keep-logs
> 
> -Murali
> 
> 
> 
> 
> 
> On Jun 15, 2015, at 11:19 PM, Keith Bray <keith.bray at RACKSPACE.COM> wrote:
> 
>> Regardless of what the API defaults to, could we have the CLI prompt/warn so that the user easily knows that both options exist?  Is there a precedent within OpenStack for a similar situation?
>> 
>> E.g. 
>> > solum app delete MyApp
>>          Do you want to also delete your logs? (default is Yes):  [YES/no]
>>               NOTE, if you choose No, application logs will remain on your account. Depending on your service provider, you may incur on-going storage charges.  
>> 
>> Thanks,
>> -Keith
>> 
>> From: Devdatta Kulkarni <devdatta.kulkarni at RACKSPACE.COM>
>> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev at lists.openstack.org>
>> Date: Monday, June 15, 2015 9:56 AM
>> To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev at lists.openstack.org>
>> Subject: Re: [openstack-dev] [Solum] Should logs be deleted when we delete an app?
>> 
>> Yes, the log deletion should be optional.
>> 
>> 
>> The question is what should be the default behavior. Should the default be to delete the logs and provide a flag to keep them, or keep the logs by default and provide a override flag to delete them?
>> 
>> Delete-by-default is consistent with the view that when an app is deleted, all its artifacts are deleted (the app's meta data, the deployment units (DUs), and the logs). This behavior is also useful in our current state when the app resource and the CLI are in flux. For now, without a way to specify a flag, either to delete the logs or to keep them, delete-by-default behavior helps us clean all the log files from the application's cloud files container when an app is deleted.
>> 
>> This is very useful for our CI jobs. Without this, we end up with lots of log files in the application's container,
>> 
>> and have to resort to separate scripts to delete them up after an app is deleted.
>> 
>> 
>> Once the app resource and CLI stabilize it should be straightforward to change the default behavior if required.
>> 
>> - Devdatta
>> 
>> From: Adrian Otto <adrian.otto at rackspace.com>
>> Sent: Friday, June 12, 2015 6:54 PM
>> To: OpenStack Development Mailing List (not for usage questions)
>> Subject: [openstack-dev] [Solum] Should logs be deleted when we delete an app?
>>  
>> Team,
>> 
>> We currently delete logs for an app when we delete the app[1]. 
>> 
>> https://bugs.launchpad.net/solum/+bug/1463986
>> 
>> Perhaps there should be an optional setting at the tenant level that determines whether your logs are deleted or not by default (set to off initially), and an optional parameter to our DELETE calls that allows for the opposite action from the default to be specified if the user wants to override it at the time of the deletion. Thoughts?
>> 
>> Thanks,
>> 
>> Adrian
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev