[openstack-dev] [Ironic] Adopting ironic-lib in Ironic

Dmitry Tantsur dtantsur at redhat.com
Tue Jun 16 07:12:09 UTC 2015


On 06/16/2015 08:58 AM, Ramakrishnan G wrote:
>
> Hi All,
>
> Some time back we created a new repository[1] to move all the reusable
> code components of Ironic to a separate library.  The branched out code
> has changed and there has been a review out to sync it [2].  But
> unfortunately, it has got stale again as some more changes have gone in
> to the branched out code.  To avoid repeated efforts of such syncing, I
> suggest we sync the latest code from Ironic to ironic-lib (in
> appropriate files) and immediately change Ironic to start using it.
>
> I suggest we can do the following:
> 1) Decide on a timeline for the change (1 or 2 days)

Now is a good time, IMO, I don't think we're in pressing need to change 
this code.

> 2) Stop +Aing changes in Ironic to the files/code being moved to ironic-lib
> 3) Sync the latest code in ironic-lib and merge it
> 4) Make a new release of ironic-lib
> 5) Make changes in Ironic to use ironic-lib and make sure gate is back
> up and running again (I can't think of anything that will break gate on
> switching to ironic-lib as it's just a pip install)

Note that this will need adding ironic-lib to global-requirements, which 
will take time, unless you grab a couple of g-r cores to do it asap.

> 6) Make new reviews in ironic-lib for any pending reviews in Ironic
>
> If we come to an agreement on #1 and #2 above, Syed Ismail Faizan
> Barmawer can continue to work on #3 - #5
>
> Let me know if it will work out or if there are any better plans (or I
> am missing something)

Otherwise plan LGTM

>
> Thanks.
>
> [1] https://github.com/openstack/ironic-lib
> [2] https://review.openstack.org/#/c/162162/
>
> Regards,
> Ramesh
>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>




More information about the OpenStack-dev mailing list