[openstack-dev] [Magnum] Make functional tests voting
adrian.otto at rackspace.com
Mon Jun 15 17:47:37 UTC 2015
Yes, let’s make it voting now. I went through the full review queue over the weekend, and I did find a few examples of functional tests timing out after 2 hours. It did not look to me like they actually ran, suggesting a malfunction in the setup of the test nodes. There we only one or two like that in the few dozen patches I looked at. I think I ordered one recheck. If that happens a lot, we might need to revisit this decision, but in all honesty I’d prefer to have the pressure of a malfunctioning gate blocking us so that we are motivated to resolve the issue at the root cause.
> On Jun 15, 2015, at 10:21 AM, Davanum Srinivas <davanum at gmail.com> wrote:
> +1 from me Tom.
> On Mon, Jun 15, 2015 at 1:15 PM, Tom Cammann <tom.cammann at hp.com> wrote:
>> I haven't seen any false positives in a few weeks from the functional
>> tests, but I have seen a couple reviewers missing the -1 from the non-voting
>> when there has been a legitimate failures.
>> I think now would be a good time to turn 'check-functional-dsvm-magnum' to
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> Davanum Srinivas :: https://twitter.com/dims
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
More information about the OpenStack-dev