[openstack-dev] [puppet] openstacklib::db::sync proposal
mmagr at redhat.com
Wed Jun 3 12:32:30 UTC 2015
On 06/02/2015 07:05 PM, Mathieu Gagné wrote:
> On 2015-06-02 12:41 PM, Yanis Guenane wrote:
>> The openstacklib::db::sync is currently only a wrapper around an exec
>> that does the actual db sync, this allow to make any modification to the
>> exec into a single place. The main advantage IMO is that a contributor
>> is provided with the same experience as it is not the case today across
>> all modules.
> The amount of possible change to an exec resource is very limited.  I
> don't see a value in this change which outweighs the code churn and
> review load needed to put it in place. Unless we have real use cases or
> outrageously genius feature to add to it, I'm not in favor of this change.
> Furthermore, any change to the public interface of
> openstacklib::db::sync would require changes across all our modules
> anyway to benefit from this latest hypothetical feature. I think we are
> starting to nitpick over as little "generic" code we could possibly find
> to put in openstacklib.
>  https://docs.puppetlabs.com/references/latest/type.html#exec
Wearing my consistency hat I must say I like this change. On the other
hand I agree with Mathieu that delegating single resource from several
modules to single module is necessary in this case.
More information about the OpenStack-dev