[openstack-dev] [infra] Getting notified of closed pull requests on github?

Joshua Harlow harlowja at outlook.com
Thu Jul 30 23:46:20 UTC 2015


Clark Boylan wrote:
> On Wed, Jul 29, 2015, at 09:14 AM, Joshua Harlow wrote:
>> Every now and then I go look at github to see what pull requests have
>> been auto-closed there, since it seems most of the repos under
>> https://github.com/openstack/(.*) auto-close pull requests (with
>> messages telling people to use gerrit);
>>
>> I'm wondering though if there is anyway to notify the maintainers in
>> gerrit that this has happened?
>>
>> For example anytime a PR is closed on say:
>>
>> https://github.com/openstack/taskflow/pulls?q=is%3Apr+is%3Aclosed
>>
>> A email could be sent to all of:
>>
>> https://review.openstack.org/#/admin/groups/173,members
>>
>> Letting those members there know that a PR was closed, and so that those
>> members can then try to avoid losing a contribution from a person that
>> was just trying to do 'good' (by making a PR in the first place).
>>
>> Is anything like that possible, it would very much help in *not* losing
>> these types of contributions (and new members to our community) because
>> currently I have a feeling that most people don't even know that such
>> pull requests are getting closed automagically.
>>
>> For example:
>>
>> -
>> https://github.com/openstack/oslo.messaging/pulls?q=is%3Apr+is%3Aclosed
>> (3 here)
>> - https://github.com/openstack/nova/pulls?q=is%3Apr+is%3Aclosed (alot
>> here)
>> - https://github.com/openstack/glance/pulls?q=is%3Apr+is%3Aclosed (3
>> here)
>> - .... and so on
>>
> Would it be simpler to subscribe to the projects on Gitub and have it
> notify you directly of project activity?

Hmmm, good idea, might try that,

Other idea is that there could be a 
openstack-closed-pull-requests at lists.openstack.org mailing list that 
cores/others could subscribe to if they want, and any time a automatic 
close happens, a mail gets sent to that list, then readers of that list 
can decide if they want to go find that person that made the PR and try 
to get it merged (I wonder if many people that submitted pull requests 
[and got it closed on them] even went through the effort to sign the 
ICLA/CCLA and submit a gerrit review, or did they just give up? Seems 
like that data should be somewhat easily determinable...)

>
> Clark
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



More information about the OpenStack-dev mailing list