[openstack-dev] [Neutron] Concern about networking-sfc and community process
Cathy.H.Zhang at huawei.com
Fri Jul 17 17:48:05 UTC 2015
I was on IRC Infra channel yesterday getting guidance about the merge.
I have replied to all the other comments on the new version 12 and addressed them in the latest updated version, but I did not spot yours since yours is towards the end of the spec and Louis, not I, replied to your comment. I apologize for this! I am usually careful and addressing all comments posted (even after the PTL approval). Yesterday I was in a little rush and was busy switching between intranet for checking the Jenkin email notification and external Internet for getting on the IRC channel and updating/checking in new versions.
After I spotted your latest “-1” yesterday, I had replied that I will upload a follow-up patch to add the API endpoints and URL info in the wiki to this spec. Apologize again for this!
From: Kyle Mestery [mailto:mestery at mestery.com]
Sent: Friday, July 17, 2015 8:13 AM
To: OpenStack Development Mailing List (not for usage questions)
Cc: Cathy Zhang
Subject: Re: [openstack-dev] [Neutron] Concern about networking-sfc and community process
On Thu, Jul 16, 2015 at 8:39 PM, Sean M. Collins <sean at coreitpro.com<mailto:sean at coreitpro.com>> wrote:
You recently merged the following patch, by +2'ing and then
Workflow+1'ing it, without allowing reviewers the chance to look at the
changes between the patchset where there were -1's and the newer
I do see that you were asking on -infra about the mechanics of how to
merge a patch
Just because a core member has given it a +2 and the Neutron PTL had
+2'd a previous patch, doesn't mean that you should go ahead and
unilaterally approve your own patch. That's not a way to build a
I agree with Sean here. The patch merged with only a single +2, and if the other comments were not addressed earlier, they need to be addressed with a followup patch (and reply on this email thread with the patch), or we should revert the commit and address them there.
Sean M. Collins
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe<http://OpenStackemail@example.com?subject:unsubscribe>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev