[openstack-dev] [Neutron] Concern about networking-sfc and community process
mestery at mestery.com
Fri Jul 17 15:13:14 UTC 2015
On Thu, Jul 16, 2015 at 8:39 PM, Sean M. Collins <sean at coreitpro.com> wrote:
> Hi Cathy,
> You recently merged the following patch, by +2'ing and then
> Workflow+1'ing it, without allowing reviewers the chance to look at the
> changes between the patchset where there were -1's and the newer
> I do see that you were asking on -infra about the mechanics of how to
> merge a patch
> Just because a core member has given it a +2 and the Neutron PTL had
> +2'd a previous patch, doesn't mean that you should go ahead and
> unilaterally approve your own patch. That's not a way to build a
> commmunity project.
I agree with Sean here. The patch merged with only a single +2, and if the
other comments were not addressed earlier, they need to be addressed with a
followup patch (and reply on this email thread with the patch), or we
should revert the commit and address them there.
> Sean M. Collins
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev