[openstack-dev] [Neutron] - breaking changes for plugins/drivers

Gary Kotton gkotton at vmware.com
Wed Jul 1 13:33:48 UTC 2015

One of the hidden costs of an external plugin that things break. This is something that happens to us at least once a week. We have been proactive in this by doing the following:

  1.  Running the decomposed plugin unit tests with every neutron change - this gives us an indication of which patch broke and why
  2.  Running the Ci

The onus is on the decomposed maintainers.

Having said that the ability to actually do some development is liberating.

A luta continua

From: Kevin Benton <blak111 at gmail.com<mailto:blak111 at gmail.com>>
Reply-To: OpenStack List <openstack-dev at lists.openstack.org<mailto:openstack-dev at lists.openstack.org>>
Date: Wednesday, July 1, 2015 at 1:49 PM
To: OpenStack List <openstack-dev at lists.openstack.org<mailto:openstack-dev at lists.openstack.org>>
Subject: Re: [openstack-dev] [Neutron] - breaking changes for plugins/drivers

>For the second one, I think we made it clear before that no plugins must rely on neutron.openstack.* contents.

Where was this made clear? I didn't know about this until it broke and I'm a very frequent contributor and reviewer, which is the core of my complaint. The updated wiki is helpful, but doing it after-the-fact only helps when people try to figure out why they can't make changes to their repos.

In that patch there were 3 in-tree third party plugins that had to be updated. That should have given a hint that it was likely to break other plugins as well. The other annoying lesson from that is that plugins/drivers still in tree are getting better treatment than the ones that went through the split process.

We need to be much more diligent about announcing these things ahead of time or we need to be clear that Neutron is completely unstable as a framework and third party drivers should basically never import anything from the neutron namespace.

On Tue, Jun 30, 2015 at 11:58 PM, Ihar Hrachyshka <ihrachys at redhat.com<mailto:ihrachys at redhat.com>> wrote:
Hash: SHA256

On 07/01/2015 08:22 AM, Kevin Benton wrote:
> Hi,
> We have had at least two breaking changes merge this week for
> out-of-tree drivers/plugins. These are just the two I noticed that
> broke the Big Switch CI (the one I keep an eye on since I had set
> it up):
> 1. Removed test_lib that changes config files.
> https://review.openstack.org/#/c/196583/ 2. Removed the loopingcall
> common util with no deprecation cycle or announcement.
> https://review.openstack.org/#/c/192999/
> I proposed a revert for 1 that merged, but I don't particularly
> want to keep fighting this. What is our current policy on this?
> Just change whatever we want and tell plugin maintainers this is
> just the way things work?

For the first one, the revert is justified.

For the second one, I think we made it clear before that no plugins
must rely on neutron.openstack.* contents.

Now I've made it mentioned at:

If your plugin is using any of neutron.openstack.* contents, just stop
doing it. It's going to break.

Version: GnuPG v2


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe<http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>

Kevin Benton
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150701/fed1230a/attachment.html>

More information about the OpenStack-dev mailing list