[openstack-dev] [Ironic] [Inspector] Addition to ironic-inspector-core, switching to 2x +2 rule

Yuiko Takada yuikotakada0313 at gmail.com
Wed Jul 1 10:09:02 UTC 2015


Thanks for all the support!!
I will do my best to meet the expectations of you.
Let's make Ironic Inspector better and better together.

As our core team grows, I'd like us to try to stick with 2x +2 rules. Up to
> now it was mostly "Dmitry approves everything" rule, now let us make sure
> we have at least 2 +2 on a patch before merging it, unless it's critical
> for release or fixing gate. Don't wait for me to W+1 if you see that patch
> already has 2x +2.
>
> I'd ask the core team to review all the incoming patches. Once our
> devstack gate is finally working, review will be a lot easier.

Nice :) +2!


Best Regards,
Yuiko Takada


2015-07-01 17:56 GMT+09:00 Dmitry Tantsur <dtantsur at redhat.com>:

> Hi all!
>
> Please welcome Yuiko Takada to ironic-inspector-core team. Yuiko has been
> with the team for some time already. She did substantial work on porting
> ironic-inspector to Oslo libraries and on our new devstack gate job.
>
> Thanks Yuiko, it's a pleasure to work with you.
>
> As our core team grows, I'd like us to try to stick with 2x +2 rules. Up
> to now it was mostly "Dmitry approves everything" rule, now let us make
> sure we have at least 2 +2 on a patch before merging it, unless it's
> critical for release or fixing gate. Don't wait for me to W+1 if you see
> that patch already has 2x +2.
>
> I'd ask the core team to review all the incoming patches. Once our
> devstack gate is finally working, review will be a lot easier.
>
> Cheers,
> Dmitry
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150701/fe8a4d3c/attachment-0001.html>


More information about the OpenStack-dev mailing list