Open Stack

On Feb 19, 2015, at 11:52, Terry Wilson <twilson at redhat.com> wrote:

> Unfortunately, the new novaclient release ended up completely breaking the neutron gate. The v1_1 deprecation broke our (voting) pylint test: https://jenkins04.openstack.org/job/gate-neutron-pylint/1383/console
> 
> 2015-02-19 18:37:06.932 | Module neutron.notifiers.nova
> 2015-02-19 18:37:06.932 | No name 'client' in module 'novaclient.v1_1' (no-name-in-module)
> 2015-02-19 18:37:06.932 | No name 'contrib' in module 'novaclient.v1_1'(no-name-in-module)
> 2015-02-19 18:37:06.932 | Module neutron.plugins.cisco.l3.service_vm_lib
> 2015-02-19 18:37:06.932 | No name 'client' in module 'novaclient.v1_1' (no-name-in-module)

Hi Terry,

Sorry to hear about this. I looked into this and the problem is pylint can't parse the backward-compatibility we have for the v1_1 deprecation:

https://review.openstack.org/#/c/149006/13/novaclient/v1_1/__init__.py,cm

The actual code should work but pylint static checking will fail to follow it. So far, the options I see to handle it are to either patch s/novaclient.v1_1/novaclient.v2/ in neutron or suppress the specific pylint check that's failing (if it's not too broad).

Do you find either of these options acceptable, or have another idea?

Thanks,
melanie (melwitt)




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150219/f6bb24eb/attachment.pgp>