[openstack-dev] [neutron][neutron-*aas] Is lockutils-wrapper needed for tox.ini commands?

Ihar Hrachyshka ihrachys at redhat.com
Mon Feb 16 13:16:37 UTC 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/13/2015 11:13 PM, Paul Michali wrote:
> I see that in tox.ini, several commands have lockutils-wrapper
> prefix on them in the neutron-vpnaas repo. Seems like this was
> added as part of commit 88e2d801 for Migration to
> oslo.concurrency.

Those would be interesting for unit tests only. And now that neutron
BaseTestCase uses proper fixture [1], we can just remove the wrapper
call from all *aas repos.

That was actually one of the things I was going to do as a oslo
liaison during Kilo [2] (see the 1st entry in the todo list.) But if
you want to go with this before I reach this cleanup, I will be glad
to review the changes. :)

[1]:
http://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/base.py#n89
[2]:
http://lists.openstack.org/pipermail/openstack-dev/2015-January/054753.html

/Ihar
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJU4e21AAoJEC5aWaUY1u57zKcH/iZ3SFi3BmyYaEwch5jipbzw
Byxn2QxyjRNcQ6m/dr6ihpvXS2bIo75mrNajc+mdnKTqAdXebceSQRPAw4EX3c9r
qtlaGzSrBqmSiyl/YnbqUiUf2zcXpFIpiTJswbdhv10P5Gi/Q64m6d+ipQsIUaMP
4sY/0sjAV5Gn9cpkBZn9LY1/CrWnP7eqFMBYvFTsyEpGHdgJ4heAx2dLCqY2DE9H
bVFexZK1yMqLzEIwmHtzSyifcFZkC39fa6bsxCVlLkbfU7+KC56FOOHARsjf+grd
ReQuGH4QIS0aTMkrd7qmJRkaK7BudkX1yfOY68jsYSwrpKoia7pMZ+tbPosfUbk=
=+HKf
-----END PGP SIGNATURE-----



More information about the OpenStack-dev mailing list