[openstack-dev] Please stop reviewing code while asking questions

Zaro zaro0508 at gmail.com
Sat Apr 25 15:41:55 UTC 2015

To follow up on Robert's post, Gerrit's query command [1] supports the
retrieval of comments for each patchset so maybe we just need to add the
'--comments' option when requesting changes [2] ?

Since I've posted, I'll just provide my own opinion on this topic.  I have
no problems with a -1 ask a question vote for any reason but I do think
that it's irresponsible to _not_ follow up.  So it's the follow up that I
would like to see fixed not the restriction on reviews because I feel that
it would discourage reviews.

[1] https://review.openstack.org/Documentation/cmd-query.html

On Fri, Apr 24, 2015 at 9:04 PM, Robert Collins <robertc at robertcollins.net>

> I believe we'll need to switch to the REST JSON API, which gertty uses
> and gets comments -> some nontrivial refactoring implied, and I
> shudder to think about the performance impact.
> I've wanted to rewrite reviewstats for a while... this might be the
> trigger...
> -Rob
> --
> Robert Collins <rbtcollins at hp.com>
> Distinguished Technologist
> HP Converged Cloud
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150425/4672229f/attachment.html>

More information about the OpenStack-dev mailing list