[openstack-dev] Please stop reviewing code while asking questions

Robert Collins robertc at robertcollins.net
Sat Apr 25 03:56:06 UTC 2015


On 25 April 2015 at 00:11, Russell Bryant <rbryant at redhat.com> wrote:
> On 04/24/2015 07:21 AM, Amrith Kumar wrote:
>> We had a hypothesis about why +0 was rarely used (never conclusively
>> proved). Our hypothesis was that since Stackalytics didn't count +0's
>> it led to an increased propensity to -1 something. It would be
>> wonderful if we could try the experiment of giving credit for 0's and
>> seeing if it changes behavior.
>
> I think this makes a lot of sense.  These stats really do drive
> behavior.  I'd certainly be open to a patch to reviewstats [1] to count
> +0 comments and I think it would be good for stackalytics to consider
> the same.
>
> [1] http://git.openstack.org/cgit/openstack-infra/reviewstats

IIRC the limit was gerrit, not reviewstats, and we've not revisited
since the gerrit upgrade.

-Rob

-- 
Robert Collins <rbtcollins at hp.com>
Distinguished Technologist
HP Converged Cloud



More information about the OpenStack-dev mailing list