Open Stack

On Fri, Apr 24, 2015 at 11:16 AM, Julien Danjou <julien at danjou.info> wrote:

> On Fri, Apr 24 2015, Joe Gordon wrote:
>
> > When I get a -1 on one of my patches with a question, I personally treat
> it
> > as a short coming of the commit message. To often in the past I have
> looked
> > at a file, and in trying to figure out why that line is there I do a git
> > blame only to see a useless commit message with me as the author.
>
> That's a thing that I've been stated over and over again in this thread
> and actually paraphrased from the first paragraph on my original email.
> It'd be cool if we could stop restating the obvious over and over again.
>


So you did, sorry.



>
>
> Could someone give me an example of how we are supposed to improve the
> patch or commit message when one get a -1 with e.g. the question:
>   "Why do you use getattr(foo, "bar", None)?"
>
>
By calling them out in the review or on irc, and explain to them when its
appropriate to use a -1.   I don't think its safe to assume that a
significant number of people who do these -1s are read every thread on the
ML.



> when the answer is "Well, otherwise it will raise an error and the code
> will fail" because the reviewer do not know how getattr() works.
>
> --
> Julien Danjou
> // Free Software hacker
> // http://julien.danjou.info
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150424/a7267eb1/attachment.html>