[openstack-dev] [metrics] what answers do you expect from counting comments? (was Re: Please stop reviewing code while asking questions)

Amrith Kumar amrith at tesora.com
Fri Apr 24 16:50:02 UTC 2015


I'm not interested in these numbers, personally (well, other than the usual fishing stories at summit after umpteen beers; I did 14 bazillion reviews in Kilo, how many did you do?).

My concern (earlier in the thread) is that there is a metric. Once there's a metric someone attempts to use it to measure performance. And once someone uses a metric to measure performance, it influences behavior.

If I propose that a +0 should now get counted, given how overloaded the CI is, I don't want the system to get abused by wanton 'recheck's which start to count towards performance.

Personally real metrics are things like new features, time to merge, time to resolve bugs and those are the kinds of things you measure in your QAR's.

My 2c worth,


| -----Original Message-----
| From: Stefano Maffulli [mailto:stefano at openstack.org]
| Sent: Friday, April 24, 2015 11:58 AM
| To: openstack-dev at lists.openstack.org
| Subject: [openstack-dev] [metrics] what answers do you expect from
| counting comments? (was Re: Please stop reviewing code while asking
| questions)
| On Fri, 2015-04-24 at 15:02 +0000, Amrith Kumar wrote:
| >
| > I would support changes to both reviewstats and stackalytics to do the
| > following.
| >
| > 1. recognizes and gives credit to '0' comments 2. identifies recheck,
| > reverify and similar directives to the CI system and flag them
| > appropriately, potentially as not being reviews but something else.
| I'm intrigued by this request. In the Quarterly Activity Reports[1] I am
| more interested in time to merge (the time for a changeset to go from
| first proposal to merged), time to respond (for human interations in
| comments) and iterations (how many patchsets in a changeset).
| I wonder if I should expand the scope of the reports.  Can you elaborate
| why you are interested in this sort of count?
| /stef
| [1]
| http://superuser.openstack.org/articles/openstack-breaks-a-new-record-for-
| active-contributors
| [1]
| http://git.openstack.org/cgit/openstack-infra/activity-
| board/plain/reports/2015-q1/pdf/2015-q1_OpenStack_report.pdf
| __________________________________________________________________________
| OpenStack Development Mailing List (not for usage questions)
| Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
| http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

More information about the OpenStack-dev mailing list