Open Stack

Ivan,

+1 to adding reviews to openstack/hacking as these are cross-project.
we can debate the merits of each rule in gerrit review as usual.

thanks,
dims

On Tue, Mar 31, 2015 at 3:19 PM, Ivan Kolodyazhny <e0ne at e0ne.info> wrote:
> Hi all,
>
> After moving to oslo.log and a lots of reviews to Cinder we merged some
> parts for hacking checks to our code [1], [2]. Some of them are also
> implemented in Nova [2], [3]. I didn't check other projects.
>
> We try to make our code following logging guidelines [5], [6] and making
> cross-project hacking checks for all logging guidelines will help every
> project.
>
> Does anybody from oslo and other project interested in it? If it it needed
> for oslo.log, I really hope in it, I could be a volunteer to move hacking
> checks inside openstack-dev/hacking or oslo.log project.
>
>
>
> [1]
> https://github.com/openstack/cinder/blob/master/cinder/hacking/checks.py#L140
> - validate_log_translations
> [2]
> https://gino_translate_debug_logsthub.com/openstack/cinder/blob/master/cinder/hacking/checks.py#L72
> -
> [3]
> https://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L294 -
> no_translate_debug_logs
> [4]
> https://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L337 -
> validate_log_translations
> [5]
> http://docs.openstack.org/developer/oslo.log/usage.html#general-logging-guidelines
> [6]
> http://docs.openstack.org/developer/oslo.log/usage.html#migrating-to-oslo-log
>
>
> Regards,
> Ivan Kolodyazhny,
> Software Engineer,
> Mirantis Inc.
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Davanum Srinivas :: https://twitter.com/dims