[openstack-dev] [oslo] oslo.i18n adapter should be created or copied from _i18n.py?

Doug Hellmann doug at doughellmann.com
Sat Oct 18 11:34:42 UTC 2014


You need both. 

The one in openstack/common is for the incubated modules. Each project should also have it's own integration module. 

Doug

> On Oct 17, 2014, at 7:50 AM, Akihiro Motoki <amotoki at gmail.com> wrote:
> 
> During migrating to oslo.i18n, I have a question whether I should
> create oslo.i18n adapater or copy it from openstack.common._i18n?
> What is the recommended way as oslo.i18n team?
> 
> oslo.i18n document [1] suggests to create oslo.i18n adapter
> in the project directory out side of openstack/common directory.
> It works when a project no longer uses any oslo-incubator modules.
> 
> On the other hand, oslo-incubator has openstack/common/_i18n.py
> and several oslo-incubator modules like policy.py uses it.
> update.sh script updates the line to <project>.openstack.common._i18n and
> this means we still need openstack.common._i18n.
> 
> IMHO when considering all oslo modules are graduated,
> it looks reasonable to create <project>.i18n module suggested
> in oslo.i18n doc [1] and use it in a project code.
> We can reduce addtional code changes when all modules are graduated.
> And, if a project use any oslo-incubator module, it looks good to
> copy to use openstack.common._i18n from oslo-incubator
> for other oslo-incubator modules.
> 
> Thanks,
> Akihiro
> 
> [1] http://docs.openstack.org/developer/oslo.i18n/usage.html
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



More information about the OpenStack-dev mailing list