[openstack-dev] [horizon] Selenium (which is non-free) is back again in Horizon (Icehouse Beta 3)

Matthias Runge mrunge at redhat.com
Mon Mar 17 09:45:22 UTC 2014


On Fri, Mar 14, 2014 at 01:03:26PM +0100, Sascha Peilicke wrote:
> 
> 
> 
> Am 14. März 2014 12:32:41 schrieb Thomas Goirand <zigo at debian.org>:
> 
> >Hi,
> >
> >A few months ago, I raised the fact that Selenium *CANNOT* be a hard
> >test-requirements.txt build-dependency of Horizon, because it is
> >non-free (because of binaries like the browser plug-ins not being
> >build-able from source). So it was removed.
> >
> >Now, on the new Icehouse beta 3, it's back again, and I get some unit
> >tests errors (see below).
> >
> >Guys, could we stop having this kind of regressions, and make Selenium
> >tests not mandatory? They aren't runnable in Debian.
> 
> Identical situation with openSUSE. And I guess Fedora is no different.

An additional note:

I was very astonished to see that now included in Fedora; it looks like
it was sufficient to remove the pre-compiled blob

%install
%{__python2} setup.py install --skip-build --root %{buildroot}

rm -f
%{buildroot}%{python2_sitelib}/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so
rm -f
%{buildroot}%{python2_sitelib}/selenium/webdriver/firefox/x86/x_ignore_nofocus.so

%if %{with python3}
pushd %{py3dir}
%{__python3} setup.py install --skip-build --root %{buildroot}
popd
rm -f
%{buildroot}%{python3_sitelib}/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so
rm -f
%{buildroot}%{python3_sitelib}/selenium/webdriver/firefox/x86/x_ignore_nofocus.so
%endif


(the review request is here: [1])

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1070125

Matthias
-- 
Matthias Runge <mrunge at redhat.com>



More information about the OpenStack-dev mailing list