I disagree to moving this logic to "tempest/services/*". The idea of these modules - assemble requests and return responses. Testing and verification should be wrapped over it. Either base class or tests, it depends on situation... -- Kind Regards Valeriy Ponomaryov On Thu, Mar 13, 2014 at 6:55 AM, Christopher Yeoh <cbkyeoh at gmail.com> wrote: > Hi, > > The new tempest body response validation is being added to individual > testcases. See this as an example: > > https://review.openstack.org/#/c/78149 > > After having a look at https://review.openstack.org/#/c/80174/ > I'm now thinking that perhaps we should be doing the response validation > in the tempest/services/compute classes. And only check the > response body if the status code is a success code (and then check that > it is an appropriate success code). > > I think this will lead to fewer changes needed in the end as the > response body checking will not needed to be added to individual tests. > > There may be some complications with handling extensions, but I think > they are all implement backwards compatible behaviour so should be ok. > > Anyone have any thoughts about this alternative approach? > > Regards, > > Chris > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev at lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140313/8e9af097/attachment.html>