Open Stack

On Wed, Mar 12, 2014 at 6:40 AM, Sean Dague <sean at dague.net> wrote:

> On 03/12/2014 09:01 AM, Flavio Percoco wrote:
> > On 11/03/14 16:25 -0700, Clint Byrum wrote:
> >> Hi. I asked in #openstack-glance a few times today but got no response,
> >> so sorry for the list spam.
> >>
> >> https://review.openstack.org/#/c/79710/
> >>
> >> This change introduces a backward incompatible change to defaults with
> >> Havana. If a user has chosen to configure swift, but did not add swift
> >> to the known_stores, then when that user upgrades Glance, Glance will
> >> fail to start because their swift configuration will be invalid.
> >>
> >> This broke TripleO btw, which tries hard to use default configurations.
> >>
> >> Also I am not really sure why this approach was taken. If a user has
> >> explicitly put swift configuration options in their config file, why
> >> not just load swift store? Oslo.config will help here in that you can
> >> just add all of the config options but not actually expect them to be
> >> set. It seems entirely backwards to just fail in this case.
> >>
> >
> > Here's an attempt to fix this issues without reverting the patch.
> > Feedback appreciated.
> >
> > https://review.openstack.org/#/c/79935/
>
> ACK. Looks pretty good. You might want to consider using one of the oslo
> deprecation functions to make it consistent on the deprecation side.
>
>         -Sean
>
> --
> Sean Dague
> Samsung Research America
> sean at dague.net / sean.dague at samsung.com
> http://dague.net
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
Sorry, I suppose I should have interrogated the backwards-incompatibility
assumptions people were making about this change a bit more.

It looks like the latest patch is a great deprecation mechanism. Thanks for
working out a solution, Flavio et al.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140312/352643bc/attachment.html>