[openstack-dev] [Nova] Spec Review Day Today!

Russell Bryant rbryant at redhat.com
Wed Jun 25 21:58:10 UTC 2014


On 06/25/2014 05:23 AM, John Garbutt wrote:
> As previously (quietly) announced, today we are trying to do a push on
> nova-specs reviews.
> 
> https://review.openstack.org/#/q/status:open+project:openstack/nova-specs,n,z
> 
> The hope is we get through some of the backlog, with some interactive
> chat on IRC in #openstack-nova
> 
> If someone has better stats on our nova-spec reviews, do respond with
> a link, and that would be appreciated. We need to track reviews that
> need reviewer attention vs submitter attention.

It's the end of my day at least (there's still some time left for those
in the western US).

The majority of specs are waiting on an update from the submitter.  I
didn't grab these stats before today, but I believe we made some good
progress.

Using: $ openreviews -u russellb -p projects/nova-specs.json

> Projects: [u'nova-specs']
--> Total Open Reviews: 111
--> Waiting on Submitter: 87
--> Waiting on Reviewer: 24

The wait times still aren't amazing though.  There's a pretty big
increase in wait time as you look at older ones.  It seems there's a set
we've been all avoiding for one reason or another that deserve some sort
of answer, even if it's "we're just not interested enough".

--> Stats since the latest revision:
----> Average wait time: 12 days, 11 hours, 30 minutes
----> 1st quartile wait time: 2 days, 9 hours, 5 minutes
----> Median wait time: 8 days, 6 hours, 6 minutes
----> 3rd quartile wait time: 21 days, 1 hours, 21 minutes
----> Number waiting more than 7 days: 12
--> Stats since the last revision without -1 or -2 :
----> Average wait time: 13 days, 1 hours, 8 minutes
----> 1st quartile wait time: 2 days, 9 hours, 5 minutes
----> Median wait time: 9 days, 2 hours, 32 minutes
----> 3rd quartile wait time: 21 days, 1 hours, 21 minutes
--> Stats since the first revision (total age):
----> Average wait time: 42 days, 18 hours, 44 minutes
----> 1st quartile wait time: 14 days, 0 hours, 27 minutes
----> Median wait time: 50 days, 12 hours, 9 minutes
----> 3rd quartile wait time: 75 days, 6 hours, 25 minutes

Another stat we can look at is how many specs we merged:

https://review.openstack.org/#/q/project:openstack/nova-specs+status:merged,n,z

It looks like we've merged 11 specs in the last 24 hours or so, and only
about 5 more if we look at the last week.

Finally, we can look at review stats:  Here's review numbers for the
last week:

Using: $ reviewers -u russellb -p projects/nova-specs.json -d 7

Reviews for the last 7 days in nova-specs
** -- nova-specs-core team member
+-----------------------------+---------------------------------------+----------------+
|           Reviewer          | Reviews   -2  -1  +1  +2  +A    +/- % |
Disagreements* |
+-----------------------------+---------------------------------------+----------------+
|           jogo **           |      39    3  21   0  15   8    38.5% |
   2 (  5.1%)  |
|           danms **          |      24    0  22   1   1   0     8.3% |
   0 (  0.0%)  |
|         russellb **         |      20    1   8   0  11   3    55.0% |
   1 (  5.0%)  |
|          philip-day         |      18    0  10   8   0   0    44.4% |
   4 ( 22.2%)  |
|        johngarbutt **       |      16    0  10   0   6   2    37.5% |
   2 ( 12.5%)  |
|           jaypipes          |      14    0   6   8   0   0    57.1% |
   2 ( 14.3%)  |
|          alaski **          |      12    0   5   1   6   2    58.3% |
   1 (  8.3%)  |
|            sdague           |       9    0   7   2   0   0    22.2% |
   0 (  0.0%)  |
|           berrange          |       7    0   4   0   3   0    42.9% |
   0 (  0.0%)  |
|            sbauza           |       7    0   5   2   0   0    28.6% |
   2 ( 28.6%)  |
|           jichenjc          |       6    0   1   5   0   0    83.3% |
   3 ( 50.0%)  |
|             xuhj            |       5    0   3   2   0   0    40.0% |
   1 ( 20.0%)  |
|        mikalstill **        |       5    0   2   0   3   1    60.0% |
   0 (  0.0%)  |
|           sgordon           |       3    0   0   3   0   0   100.0% |
   1 ( 33.3%)  |
|            kiwik            |       3    0   2   1   0   0    33.3% |
   1 ( 33.3%)  |
|           oomichi           |       3    0   3   0   0   0     0.0% |
   0 (  0.0%)  |
|            dpamio           |       3    0   0   3   0   0   100.0% |
   0 (  0.0%)  |
|          gd-mdorman         |       2    0   0   2   0   0   100.0% |
   1 ( 50.0%)  |
|           cyeoh-0           |       2    0   0   2   0   0   100.0% |
   0 (  0.0%)  |
|           cbehrens          |       2    0   1   1   0   0    50.0% |
   0 (  0.0%)  |
|            lxsli            |       2    0   0   2   0   0   100.0% |
   1 ( 50.0%)  |
|          geekinutah         |       2    0   1   1   0   0    50.0% |
   0 (  0.0%)  |
|           pczesno           |       2    0   0   2   0   0   100.0% |
   1 ( 50.0%)  |
|        santibaldassin       |       1    0   0   1   0   0   100.0% |
   0 (  0.0%)  |
|             ptm             |       1    0   1   0   0   0     0.0% |
   0 (  0.0%)  |
|          tsekiyama          |       1    0   0   1   0   0   100.0% |
   0 (  0.0%)  |
|           unknown           |       1    0   0   1   0   0   100.0% |
   1 (100.0%)  |
|        prykhodchenko        |       1    0   1   0   0   0     0.0% |
   0 (  0.0%)  |
|           JoshNang          |       1    0   1   0   0   0     0.0% |
   0 (  0.0%)  |
|        yunhong-jiang        |       1    0   0   1   0   0   100.0% |
   0 (  0.0%)  |
|            lukego           |       1    0   1   0   0   0     0.0% |
   0 (  0.0%)  |
|         clint-fewbar        |       1    0   1   0   0   0     0.0% |
   0 (  0.0%)  |
|          devananda          |       1    0   1   0   0   0     0.0% |
   0 (  0.0%)  |
|          rpodolyaka         |       1    0   1   0   0   0     0.0% |
   0 (  0.0%)  |
|         MatthewBooth        |       1    0   1   0   0   0     0.0% |
   0 (  0.0%)  |
|           belliott          |       1    0   0   1   0   0   100.0% |
   1 (100.0%)  |
|            wingwj           |       1    0   0   1   0   0   100.0% |
   0 (  0.0%)  |


-- 
Russell Bryant



More information about the OpenStack-dev mailing list