[openstack-dev] [oslo] Adopting pylockfile

Ben Nemec openstack at nemebean.com
Mon Jun 23 14:38:38 UTC 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/23/2014 08:41 AM, Julien Danjou wrote:
> Hi there,
> 
> We discovered a problem in pylockfile recently, and after
> discussing with its current maintainer, it appears that more help
> and workforce would be require:
> 
> https://github.com/smontanaro/pylockfile/issues/11#issuecomment-45634012
>
>  Since we are using it via oslo lockutils module, I proposed to
> adopt this project under the Oslo program banner. The review to
> copy the repository to our infrastructure is up at:
> 
> https://review.openstack.org/#/c/101911/

We actually don't use this in lockutils - we use our own
implementation of LockFile because there was some sort of outstanding
bug in pylockfile that made it not work for us.  The only place I can
see that we do use that project is in the oslo.db code because we
didn't want to depend on incubator modules there, but once
oslo.concurrency graduates we can switch to using our own locking
implementation again.

Basically I think this would be duplicating what we're already doing
in lockutils, so I'm -1 on it.  I'd rather focus on getting
oslo.concurrency graduated and remove pylockfile from
global-requirements to make sure no one is using it anymore.

This also makes me wonder if oslo.concurrency should not be an oslo.*
library since this functionality is more generally applicable outside
OpenStack.  Something to discuss anyway.

> 
> Cheers,
> 
> 
> 
> _______________________________________________ OpenStack-dev
> mailing list OpenStack-dev at lists.openstack.org 
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTqDvqAAoJEDehGd0Fy7uqjOIH/RyvsUstB473A8NzDBEUyLYp
alztUIjHzClZBne0weAe10UzqWGmfSFJKhpThAB3IP9xdS39ZmW4zAGQm8obk4RL
Qj9nDPt/WRb0kMlWulTckfVR2hWDc0kZ2Y5YBFR0ubWQfNoyh14rF9VEtuVsZOwW
1/F60rlXy9iZGC/Mw+XK5ZJhoG6k7EZucDR6y0bfaNLdOWDUeEaqzq1lvfULyaYS
MZxfEFnsY1GkRxSX4U/SMvu1xV3yTkrbLXmsj3fAJBW4HQfp+9bdAfkz/Z1snYl6
VtMvfDYChJogq2c7G35RD161nxmMxsOyrLm/YSqc7dPkMytdKD3YXwAuYsiVIJM=
=YBxv
-----END PGP SIGNATURE-----



More information about the OpenStack-dev mailing list