Open Stack

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 18/06/14 13:31, Sean Dague wrote:
> On 06/18/2014 08:26 AM, Duncan Thomas wrote:
>> On 18 June 2014 10:04, Thierry Carrez <thierry at openstack.org>
>> wrote:
>> 
>>> As an aside, we don't really need two core reviewers to bless a
>>> trivial change: one could be considered sufficient. So a patch
>>> marked as trivial which has a number of +1s could be +2/APRVed
>>> directly by a core reviewer.
>>> 
>>> That would slightly reduce load on core reviewers, although I
>>> suspect most of the time is spent on complex patches, and
>>> trivial patches do not take that much time to process (or could
>>> even be seen as a nice break from more complex patch
>>> reviewing).
>> 
>> 
>> I think removing the need for two +2s is higher risk that you
>> think - the definition of 'trivial' gets stretched and stretched
>> over time because it allows people to get patches in
>> quicker/easier and we end up in a mess. I'm all for adding the
>> tag, but reducing the review requirements is, in my view,
>> dangerous. If a change is truly trivial then it is only going to
>> take moments for the second core to review it, so the saving
>> really is negligible compared to the risk.
> 
> Agreed.
> 
> Even with 2 +2s you do the wrong thing. Yesterday we landed
> baremetal tests that broke ironic. It has a ton of +1s from people
> that have been working on those tests.

This is slightly off topic, but think about that for a moment: the
patch had a ton of peer review and 2 +2s from core reviewers, and it
still broke. Review has significant benefits, but also a large cost,
and it doesn't have all the answers. The answer is not always more
review: there are other tools in the box. Imagine we spent 50% of the
time we spend on review writing tempest tests instead.

Matt

- -- 
Matthew Booth
Red Hat Engineering, Virtualisation Team

Phone: +442070094448 (UK)
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlOhoiYACgkQNEHqGdM8NJDdLwCffEvJqlR6ETt9BJPjrqN+0FpP
o18An25t4Z4NdRZEDIKu060h54Dd+PwR
=MpQW
-----END PGP SIGNATURE-----